So it seems to work. Discharge stopped at 79% (set 80%)
State is still “discharging”, but I suppose that’s because there isn’t a battery bypass circuit?
And for posterity, the charge limit set in BIOS being ignored is tracked in github.
So it didn’t stop discharging, just sloooowed down. I’m now down to 70%.
It seems setting min and max to the same number might cause it to never start charging.
This part of the fw is really buggy 
Oh you are right. That is unfortunate. The older framework_laptop module I posted above and was using until recently did not have this limitation.
I’ll do more testing on my side, but it does appear once ectool is used, the charge_control_end_threshold and start sysfs locations stop working. I have bios set to 100% but I can see this being very annoying to any users who set their bios to <100%. Hopefully something that will get fixed in a future kernel.
So just to recap for myself. This framework-laptop-kmod is not needed anymore with kernel 6.14 and up right?
Is there something else that is good to know. Just making sure before we remove this module from our uBlue images
kmod isn’t required, but probe_with_fwk_charge_control is.
For newer BIOS/firmware releases (3.09 on the 7040 and 3.03 on the 300 series), this is also required: mfd: cros_ec: Separate charge-control probing from USB-PD